Skip to content

Refactor filter components #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 1 commit into from
Jan 6, 2021
Merged

Refactor filter components #1361

pipecd-bot merged 1 commit into from
Jan 6, 2021

Conversation

@cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Jan 6, 2021

What this PR does / why we need it:

  • Create a shared component for filter view
  • Extract constants

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@cakecatz
Refactor filter components
a5a44f2 
* Create a shared component for filter view
* Extract constants
@cakecatz cakecatz changed the title Refactor filter components WIP: Refactor filter components Jan 6, 2021
@cakecatz cakecatz changed the title WIP: Refactor filter components Refactor filter components Jan 6, 2021
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 6, 2021

COVERAGE

Code coverage for golang is 34.01%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 6, 2021

COVERAGE

Code coverage for javascript is 85.02%. This pull request increases coverage by 0.03%.

File Base Head Diff
src/constants/ui-text.ts 100.00% 100.00% +0.00%
src/components/resource-filter-popover.tsx 94.12% 94.44% +0.33%

@nghialv
Copy link
Member

nghialv commented Jan 6, 2021

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Jan 6, 2021
@khanhtc1202
Copy link
Member

khanhtc1202 commented Jan 6, 2021

thank you
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 6, 2021

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit fd5c625 into master Jan 6, 2021
@pipecd-bot pipecd-bot deleted the refactor-forms branch January 6, 2021 14:11
@pipecd-bot pipecd-bot mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

@nghialv nghialv Awaiting requested review from nghialv

Assignees

No one assigned

Labels

approved area/web lgtm release-note-none size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cakecatz @pipecd-bot @nghialv @khanhtc1202